Skip to content

Deprecate vision service #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Deprecate vision service #1

wants to merge 6 commits into from

Conversation

@penguinland
Copy link
Owner

@penguinland penguinland commented Jun 30, 2025

I strongly recommend reviewing this commit-by-commit!

  • The first commit splits 1 long file into 2 smaller files, and moves 400 lines of code around without changing any functionality.
  • The second commit renames vizService to deprecatedVizService and renames NewService() to DeprecatedNewService()
  • TODO: update the plan
  • The third commit creates a new vizService and NewService(), which mainly differ from the previous ones by taking in a resource.Dependencies object instead of a robot.Robot argument.

@penguinland penguinland mentioned this pull request Jun 30, 2025
Merged
@penguinland
split vizModel to a separate file (viamrobotics#5094)
3715f4c 
vision.go was super long, and half of it was unrelated to the other half. So, it's now 2 files. This will make it easier to think about fixing RDSK-11093, which is about updating `vision.NewService()` to not use the deprecated constructor.

No changes to functionality are intended: I just took a file and split it in half.
@penguinland
rename vizModel->deprecatedVizModel and NewService->DeprecatedNewService
7fa9c8f
@penguinland
implement a non-deprecated vision.NewService
f308d39
@penguinland
refactor to remove duplicated code
b7ef87c
@penguinland
refactor: put code in a single file again
3408dd1
@penguinland
fix the tests
55dddf1
@penguinland penguinland force-pushed the deprecate_vision_service branch from a4bcd8c to 55dddf1 Compare June 30, 2025 19:24
@penguinland
Copy link
Owner Author

penguinland commented Jun 30, 2025

Closing in favor of viamrobotics#5096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@penguinland