Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email verification required as a Mixins #2158

Closed
wants to merge 6 commits into from
Closed

Email verification required as a Mixins #2158

wants to merge 6 commits into from

Conversation

simo97
Copy link

@simo97 simo97 commented Dec 3, 2018

feat(account): Added a new mixins to enable email verification control on a class-based views.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.623% when pulling e09ac00 on simo97:mixins into 6ddb0cf on pennersr:master.

@coveralls
Copy link

coveralls commented Dec 3, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 94.417% when pulling 22712c7 on simo97:mixins into 54091aa on pennersr:master.

pennersr
pennersr requested changes Jul 9, 2019
View reviewed changes
Copy link
Owner

@pennersr pennersr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes made here are not DRY -- the logic of verified_email_required is duplicated. I would prefer to see an approach where this is shared, e.g. something based on @method_decorator(verified_email_required)

@simo97
Copy link
Author

simo97 commented Aug 7, 2019

Oh ok will change that quickly.

@simo97 simo97 changed the title Mixins Email verification required as a Mixins Aug 18, 2019
@simo97
@method_decorator added on the class
2ad7fb4 
A more DRY way to check if a user has verified his email in a class based view.
@simo97
Fix some CI build errors causes
22712c7 
Tasks:
- removed some trailing spaces
- split code in multiple line to reduce the number of char on the line
pennersr
pennersr requested changes Jul 12, 2023
View reviewed changes
allauth/account/mixins.py Outdated Show resolved Hide resolved
allauth/account/mixins.py Outdated Show resolved Hide resolved
docs/decorators.rst Outdated Show resolved Hide resolved
docs/decorators.rst Outdated Show resolved Hide resolved
pennersr
pennersr requested changes Aug 12, 2023
View reviewed changes
allauth/account/mixins.py Outdated Show resolved Hide resolved
allauth/account/mixins.py Outdated Show resolved Hide resolved
@pennersr pennersr closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennersr pennersr pennersr requested changes

Assignees
No one assigned
Labels
Abandoned Needs improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simo97 @coveralls @pennersr