Deleting application submissions + version bump #542
+968
−763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cphalen Are we thinking this version bump is a good idea? It seems like a lot and might break stuff, but Django 4.1 does seem pretty cool especially with all its async support. Let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now deleting an application submission on a Wharton application will delete that submission and all other submissions by the same user on the same application under the same committee. This should resolve some of the complications of deleting submissions.
Also did some version bumps, largest one is to Django 4 but was pretty seamless just needed a few config changes.