fix: Deprecate membership_count #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, just in time for the new school year. Thanks Eunsoo! Good to have you back |
rohangpta
approved these changes
Aug 22, 2023
|
Feel free to squash and merge whenever. |
….members.length instead
rohangpta
force-pushed
the
fix/registered-count
branch
from
6e62096
to
1c08d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InfoBoxusesmembership_countwhich does not exist anymore.membership_countshould be removed fromClubtype definition. Seems likeInfoBoxis the only component making use of this property, so we might as well delete it, but I marked it as deprecated for safety. See types.ts.