Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests left out from ticketing #703

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add tests left out from ticketing #703

merged 2 commits into from
Jun 20, 2024

Conversation

Porcupine1
Copy link
Contributor

Resolves #702

@Porcupine1 Porcupine1 linked an issue Jun 3, 2024 that may be closed by this pull request
Add tests left out in #658 #702
Closed
@Porcupine1 Porcupine1 changed the title Added left out from tests ticketing #702 Add tests left out from ticketing #702 Jun 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.11%. Comparing base (8561edc) to head (3f0ec11).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   71.10%   71.11%           
=======================================
  Files          31       31           
  Lines        6824     6826    +2     
=======================================
+ Hits         4852     4854    +2     
  Misses       1972     1972

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Porcupine1 Porcupine1 changed the title Add tests left out from ticketing #702 Add tests left out from ticketing Jun 3, 2024
@Porcupine1 Porcupine1 mentioned this pull request Jun 3, 2024
Merged
aviupadhyayula
aviupadhyayula approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, left a few comments. Thanks for taking the initiative with this -- tests look super clean 🚀

backend/tests/clubs/test_ticketing.py Show resolved Hide resolved
backend/tests/clubs/test_ticketing.py Outdated Show resolved Hide resolved
backend/tests/clubs/test_ticketing.py Outdated Show resolved Hide resolved
backend/tests/clubs/test_ticketing.py Show resolved Hide resolved
@Porcupine1 Porcupine1 merged commit 7de7dd6 into master Jun 20, 2024
9 checks passed
@Porcupine1 Porcupine1 deleted the place_hold_give_tickets_tests branch June 20, 2024 20:35
@Porcupine1 Porcupine1 restored the place_hold_give_tickets_tests branch June 20, 2024 23:34
Porcupine1 added a commit that referenced this pull request Jun 20, 2024
@Porcupine1
Revert "Add tests left out from ticketing (#703)"
956c9c6 
This reverts commit 7de7dd6.
@Porcupine1 Porcupine1 mentioned this pull request Jun 20, 2024
Merged
Porcupine1 added a commit that referenced this pull request Jun 20, 2024
@Porcupine1
Revert "Add tests left out from ticketing (#703)" (#706)
8ed3a7e 
This reverts commit 7de7dd6.
Porcupine1 added a commit that referenced this pull request Jul 6, 2024
@Porcupine1
Resolve unaddressed nits in #703 (#707)
a3d27de 
* added tests leftout tests ticketing

* address nits

* remove TODO

* add transaction record test

* address more nits

* keep TODO

* address last nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviupadhyayula aviupadhyayula aviupadhyayula approved these changes

@rm03 rm03 Awaiting requested review from rm03

Assignees
No one assigned
Labels
backend
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests left out in #658
2 participants
@Porcupine1 @aviupadhyayula