Return unknown operation_details in parser #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanabertoldi
force-pushed
the
jb/bank-428-create-unknown-operation-details-object
branch
from
3f73c2b to
b6fef0c
Compare
joanabertoldi
force-pushed
the
jb/bank-428-create-unknown-operation-details-object
branch
from
97641f3 to
d9cb64a
Compare
joanabertoldi
requested review from
frantisekrokusek and
NathanBerthier
as code owners
lauragilgz
reviewed
Dec 3, 2024
frantisekrokusek
requested changes
Dec 3, 2024
README.md
Outdated
| @@ -33,8 +33,9 @@ gem 'cfonb' | |||
| Below is the list of additional details available for each operation. | |||
|
|
|||
| These details can be accessed through `operation.details`, which will provide all the attributes. To fetch a specific attribute, you can use `operation.details.attribute`. For example, `operation.details.unstructured_label`. Ultimately, you can also access the 70 characters of the detail by using its code like `operation.details.mmo` | |||
| All unmapped details can be accessed via `details.unknown` which will return the codes and the corresponding line details. | |||
There was a problem hiding this comment.
I would add an example of how it can look like and how to access a specific code
| @@ -15,7 +15,9 @@ def self.register(code, klass) | |||
| end | |||
|
|
|||
| def self.for(line) | |||
| @details[line.detail_code] | |||
| return unless line.respond_to?(:detail_code) | |||
There was a problem hiding this comment.
You can avoid this no by making returning an Unknown class for each unknown code ?
There was a problem hiding this comment.
We do that below, this was to prevent cases where the file might be corrupted and we didn't have a detail_code at all (since we need the detail code for both know known and unknown classes). Maybe I should raise instead?
| @@ -15,7 +15,9 @@ def self.register(code, klass) | |||
| end | |||
|
|
|||
| def self.for(line) | |||
| @details[line.detail_code] | |||
| return unless line.respond_to?(:detail_code) | |||
There was a problem hiding this comment.
Normally an unknown should respond to detail code
So this seems not relevant
frantisekrokusek
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.