Bugfix/html temp file writing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 5, 2024 13:59
kklemon
requested changes
Jun 6, 2024
| # buffering=0 is very important if you want to yield inside | ||
| # Since we don't use the delete option here (we delete manually below) | ||
| # we yield outside of this context | ||
| # The code below is essentially equivalent to `with open()...write` | ||
| with NamedTemporaryFile(prefix="penai_", suffix=extension, mode=mode, delete=False) as file: |
There was a problem hiding this comment.
I had issues with this function again yesterday and to my surprise, I actually had to figure out that we can't just use buffering=0 here as it seems to be a requirement for writing to files in text mode for whatever reason.
The solution therefore seems to be to just flush the file after writing. We should also remove the then misleading comment.
You can also stick to the current state and I will provide a PR on top.
There was a problem hiding this comment.
I removed it already I though. Also had issues
There was a problem hiding this comment.
Yes, it was already removed. Was your comment on an older version?
MischaPanch
force-pushed
the
bugfix/html-temp-file-writing
branch
from
9fa795e to
93e1554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.