Add round func to _spacing-class-generator (#777)

* add round func * npm run prod * update changelog * build * revert change * add back change * debug * add use of round func * add comment
penske-media-corp · Mar 24, 2023 · 8932a30 · 8932a30 · vercel · Mar 24, 2023
1 parent f89911f
commit 8932a30
Show file tree

Hide file tree

Showing 21 changed files with 427 additions and 98 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## Unpublished Changes
+* larva-scss - Use `round` func when generating spacing utility classes to prevent errors when converting rems to pixels for class name.
 
 ## 1.43.1 02-21-2023
 * Re-build larva JSON/versioning

diff --git a/build/css/larva-important.css b/build/css/larva-important.css
diff --git a/build/css/larva.css b/build/css/larva.css
diff --git a/build/css/larva.inline-important.css b/build/css/larva.inline-important.css
diff --git a/build/css/larva.inline.css b/build/css/larva.inline.css
diff --git a/build/js/common.js b/build/js/common.js
diff --git a/build/js/larva-ui.js b/build/js/larva-ui.js
diff --git a/build/svg/defs/sprite.defs.html b/build/svg/defs/sprite.defs.html
@@ -846,7 +846,7 @@ <h2>youtube</h2>
 
 		</section>
 		<footer>
-			<p>Generated at Tue, 14 Feb 2023 19:19:26 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
+			<p>Generated at Thu, 23 Mar 2023 18:54:47 GMT by <a href="https://github.com/svg-sprite/svg-sprite" target="_blank" rel="noopener noreferrer">svg-sprite</a>.</p>
 		</footer>
 	</body>
 </html>
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/larva-css/build/css/algorithms.common.inline.css b/packages/larva-css/build/css/algorithms.common.inline.css
diff --git a/packages/larva-css/package-lock.json b/packages/larva-css/package-lock.json
diff --git a/packages/larva-patterns/package-lock.json b/packages/larva-patterns/package-lock.json
diff --git a/packages/larva-scss/lib/tools/generators/_spacing-utility-generator.scss b/packages/larva-scss/lib/tools/generators/_spacing-utility-generator.scss
@@ -25,6 +25,10 @@
 			// Multiply by 100 to turn values less than 1 (e.g. 0.25)
 			// into non-decimals with a leading zero (e.g. 025).
 			$value: '0' + $value * 100;
+		} @else if (round($value) != $value) {
+			// If value is not a whole number (e.g. 1.5), multiply
+			// by 100 to make it so (e.g. 150).
+			$value: $value * 100;
 		}
 
 		@if (length($token) == 3) {

diff --git a/packages/larva/build/css/larva-important.css b/packages/larva/build/css/larva-important.css
diff --git a/packages/larva/build/css/larva.css b/packages/larva/build/css/larva.css
diff --git a/packages/larva/build/css/larva.inline-important.css b/packages/larva/build/css/larva.inline-important.css
diff --git a/packages/larva/build/css/larva.inline.css b/packages/larva/build/css/larva.inline.css