Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for SAS and SLO via SessionRegistry #93

Open
wants to merge 2 commits into
base: 8.1
Choose a base branch
from

Conversation

jonjarvis
Copy link
Contributor

Just submitting this PR so this code is not lost. Needs some cleanup for formatting.

@wingman-pentaho
Copy link
Collaborator

Build Completed

❌ This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pom.xml' -pl '.,pentaho-saml' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pom.xml' -pl '.,pentaho-saml' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/documentation/resources/applicationContext-spring-security-session-registry.xml
  Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/documentation/resources/pentaho-sp.xml
  Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/java/org/pentaho/platform/spring/security/saml/PentahoSAMLProcessingFilter.java
  Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/java/org/pentaho/platform/spring/security/saml/logout/PentahoSingleLogoutProfileImpl.java
  Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/resources/OSGI-INF/blueprint/blueprint.xml
  Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/resources/cfg/pentaho.saml.cfg

Unit Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes (click to expand)
🆕 org.pentaho.platform.spring.security.saml.logout.PentahoSingleLogoutProfileImpl
  • Coverage: 0%
🆕 org.pentaho.platform.spring.security.saml.PentahoSAMLProcessingFilter
  • Coverage: 0%

License header violations

❗ Couldn't find acceptable copyright on Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/java/org/pentaho/platform/spring/security/saml/PentahoSAMLProcessingFilter.java

❗ Couldn't find acceptable license on Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/java/org/pentaho/platform/spring/security/saml/PentahoSAMLProcessingFilter.java

❗ Couldn't find acceptable copyright on Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/java/org/pentaho/platform/spring/security/saml/logout/PentahoSingleLogoutProfileImpl.java

❗ Couldn't find acceptable license on Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/java/org/pentaho/platform/spring/security/saml/logout/PentahoSingleLogoutProfileImpl.java

Checkstyle violations

The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.

/home/buildguy/project/Samples_for_Extending_Pentaho/Reference Implementations/Security/SAML 2.0/pentaho-saml/src/main/java/org/pentaho/platform/spring/security/saml/logout/PentahoSingleLogoutProfileImpl.java

❗ Line has trailing spaces at Line: 21

❗ Line has trailing spaces at Line: 24

❗ Line has trailing spaces at Line: 29

❗ Line has trailing spaces at Line: 31

❗ Line has trailing spaces at Line: 39

❗ '(' is not followed by whitespace. at Line: 44 Column: 37

❗ ')' is not preceded with whitespace. at Line: 44 Column: 59

❗ Line has trailing spaces at Line: 46

❗ Line has trailing spaces at Line: 48

❗ 'catch' child has incorrect indentation level 12, expected level should be 10. at Line: 50

❗ '(' is not followed by whitespace. at Line: 50 Column: 43

❗ ')' is not preceded with whitespace. at Line: 50 Column: 104

❗ 'if' is not followed by whitespace. at Line: 54 Column: 11

❗ Line has trailing spaces at Line: 62

❗ Line has trailing spaces at Line: 64

❗ Line has trailing spaces at Line: 71

❗ Line has trailing spaces at Line: 72

❗ Line has trailing spaces at Line: 78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants