[ONE-95]: Additional Mvn Options for NPM and Node #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaikwad2
requested review from
hbfernandes,
tmcsantos,
lgrill-pentaho,
cardosov,
jmcrfp and
smaring
as code owners
|
SonarQube Quality Gate
|
✅ Build finished in 3m 58sBuild command: mvn clean verify -B -e -Daudit -amd👌 All tests passed! Tests run: 219, Failures: 0, Skipped: 1 Test Results ℹ️ This is an automatic message |
cardosov
requested changes
Dec 20, 2023
| @@ -311,7 +315,7 @@ class MavenBuilder extends AbstractBuilder implements IBuilder, Serializable { | |||
| String localSettingsFile = item.settingsFile ?: settingsFile | |||
|
|
|||
| if (item.containerized) { | |||
| process("${cmd} -V -s ${localSettingsFile} -Dmaven.repo.local='${localRepoPath}'", steps) | |||
| process("${cmd} -V -s ${localSettingsFile} -Dmaven.repo.local='${localRepoPath}' -DnodeDownloadRoot='${nodeDownloadRoot}' -DnpmDownloadRoot='${npmDownloadRoot}'", steps) | |||
There was a problem hiding this comment.
Check if nodeDownloadRoot and npmDownloadRoot are populated and if they are then add them to the cmd variable. That way we also cover the use case for non containerised builds.
And please add unit tests to cover this new work. Unit tests in the shared lib, to be clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.