[PIR-1513] - Moving some of the core classes and interface for async report generation to the reporting core library #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…report generation to the reporting core library
✅ Build finished in 58m 42sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl engine/core👌 All tests passed! Tests run: 824, Failures: 0, Skipped: 2 Test Results ℹ️ This is an automatic message |
peterrinehart
approved these changes
Sep 6, 2024
rsleem
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pentaho-jira-archive.orl.eng.hitachivantara.com/browse/BISERVER-10627 This jira introduced cancellation of the report on user's request. All of this code due to some reasons was put in reporting plugin instead of reporting-core. I have move some there classes to engine-core.
The classes and interfaces were move from https://github.com/pentaho/pentaho-platform-plugin-reporting project by this PR pentaho/pentaho-platform-plugin-reporting#855