Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prod build deployment #153

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Prod build deployment #153

merged 6 commits into from
Jul 29, 2024

Conversation

ejmg
Copy link
Collaborator

@ejmg ejmg commented Jul 29, 2024

Closes #27 #71

This is a production ready Containerfile that builds Cuiloa for production and optimizes it for packaging as an image. The docker-compose file wasn't updated as planned due to issues with building and running pd alongside cometbft and my inability to get them playing nicely with the psql indexer.

@ejmg ejmg requested a review from conorsch July 29, 2024 01:28
…g a production version of cuiloa with pd, cometbft, and the indexer.
@ejmg
Copy link
Collaborator Author

ejmg commented Jul 29, 2024

I chose to push the docker-compose file update for review but will toss it if nothing comes of it.

ejmg and others added 3 commits July 29, 2024 14:00
…llow copying of the required assets for standalone build
There's no longer a "public/" directory to copy between image layers.
I often use a local `.envrc` to customize env vars for connecting a dev
env to various external URLs. Tacking on a git-ignore rule to ensure I
don't screw up and commit those.
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Containerfile changes look great! Thanks for the hard work on that. Had to push a tiny fix to unbreak container builds in the new format, then it worked swimmingly for me.

The compose changes are harder for me to review, but I'm not going to block on that: let's land this iterative update on the compose env, and continue to bang it into shape.

@conorsch conorsch merged commit da21912 into main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use production build for container deployment
2 participants