Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #96: sub-account selector #118

Merged
merged 5 commits into from
Oct 31, 2024
Merged

feat: #96: sub-account selector #118

merged 5 commits into from
Oct 31, 2024

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Oct 31, 2024 •
edited
Loading

Closes #96

Depends on penumbra-zone/web#1886

Fetches 6 sub-accounts by indexes and allows to select one of them. Also, uses toasts to display connection errors.

image image

@VanishMax VanishMax self-assigned this Oct 31, 2024
grod220
grod220 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! The final design is still pending, but this will definitely help as we build out the other components for now.

@VanishMax VanishMax marked this pull request as ready for review October 31, 2024 17:03
@VanishMax VanishMax merged commit af43f77 into main Oct 31, 2024
2 checks passed
@VanishMax VanishMax deleted the feat/#96-subaccount-dropdown branch October 31, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

Assignees

@VanishMax VanishMax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account chooser modal
2 participants
@VanishMax @grod220