Summary data for pairs #123
Conversation
There was a problem hiding this comment.
I'd strongly advocate in favor of only having a schema for the specific tables we need here, i.e. the dex_ex tables. In particular, internal tables to pindexer should not be present here, and unrelated tables invite depending on them, whereas we instead want the app view for the dex_ex tables to be complete for this frontend.
src/shared/database/schema.ts
Outdated
| _dex_ex_queue: _DexExQueue; | ||
| _dex_ex_summary_backing: _DexExSummaryBacking; | ||
| _insights_shielded_pool_depositors: _InsightsShieldedPoolDepositors; | ||
| _insights_validators: _InsightsValidators; |
There was a problem hiding this comment.
These are internal tables which should not be depended on, since the format changes ; I'd recommend just depending on the dex_ex_... tables here, to not have to upgrade all of these in case of changes to unrelated app views.
There was a problem hiding this comment.
Sure that's fair. It would be nice if the maintenance of this schema was automated. But can pare down for now.
Relates to: #107
kyselylibrary for DB queries of the new indexer. It's typesafe, yay! 🥳