fix: use cleanUrls in firebase config #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets `cleanUrls=true` in the Firebase config [0], to fix how subpage navigation works on the hosted site. I'm not stoked that we need to perform this kind of URL rewriting at the hosting layer; I'd prefer that the build step emitted a properly structured static docroot. Refs #8. [0] https://firebase.google.com/docs/hosting/full-config#control_html_extensions
|
Visit the preview URL for this PR (updated for commit 42455b9): https://penumbra-guide--pr12-fix-sub-urls-a3fah7t9.web.app (expires Thu, 01 Aug 2024 16:19:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c64218fe717b75c9724a23946df883a1adf10faa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
cleanUrls=truein the Firebase config [0], to fix how subpage navigation works on the hosted site. I'm not stoked that we need to perform this kind of URL rewriting at the hosting layer; I'd prefer that the build step emitted a properly structured static docroot.Refs #8.
[0] https://firebase.google.com/docs/hosting/full-config#control_html_extensions