feat: remove hardcoded versions in chain-upgrade docs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
approved these changes
Aug 6, 2024
Back when the guide was managed in the Penumbra protocol repo [0], the version strings in the docs were automatically bumped in line with the source code changes. Since breaking the guide out into a separate repo, we no longer have the convenience of those automatic updates, so the guide versions will necessarily lag behind. Let's remove the hardcoded version strings from crucial reference pages like the chain-upgrade docs, leaning on node operators to choose the correct version for a given upgrade. [0] https://github.com/penumbra-zone/penumbra
conorsch
force-pushed
the
remove-hardcoded-versions
branch
from
eece35e
to
8cf94a9
Compare
|
Visit the preview URL for this PR (updated for commit 8cf94a9): https://penumbra-guide--pr26-remove-hardcoded-ver-f0vpfanh.web.app (expires Tue, 13 Aug 2024 17:08:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c64218fe717b75c9724a23946df883a1adf10faa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when the guide was managed in the Penumbra protocol repo [0], the version strings in the docs were automatically bumped in line with the source code changes. Since breaking the guide out into a separate repo, we no longer have the convenience of those automatic updates, so the guide versions will necessarily lag behind. Let's remove the hardcoded version strings from crucial reference pages like the chain-upgrade docs, leaning on node operators to choose the correct version for a given upgrade.
[0] https://github.com/penumbra-zone/penumbra