Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent orders as strings #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Represent orders as strings #6

wants to merge 1 commit into from

Conversation

zbuc
Copy link
Member

@zbuc zbuc commented May 12, 2023

Breaks for some exchange rates, e.g.

[email protected]_btc/100bps

@conorsch
Copy link
Contributor

N.B. we are not merging this PR for Testnet 52 (penumbra-zone/penumbra#2415); we'll revisit it after release, and decide whether to resolve conflicts and pull it in.

src/trader.rs Show resolved Hide resolved
tracing::info!(?sell_pos1, "opening sell position");
plan = plan.position_open(sell_pos1);

let sell_order2 = format!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this a buy order, that way you don't have to invert the midprice, and it's clear that osiris opens a buy + sell to quote each side!

src/trader.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants