fix: unbreak metadata handling for badges #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently released support for "badges" in asset metadata [0]. Since the penumbers app was pulling from the asset registry remotely, this broke the app. We should probably switch to using bundled registry data instead. For now, though, I've bumped all the Penumbra JS deps to their latest versions, which unbreaks the site. Refs #9.
cronokirby
approved these changes
Oct 31, 2024
|
Sorry about that, turns out our package is not forwards compatible with Metadata schema changes 😢 v12 of the registry addresses this issue. Will open a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently released support for "badges" in asset metadata [0]. Since the penumbers app was pulling from the asset registry remotely, this broke the app. We should probably switch to using bundled registry data instead. For now, though, I've bumped all the Penumbra JS deps to their latest versions, which unbreaks the site.
Refs #9.