Skip to content

Commit

Permalink
build(pd): upgrade to tower-abci v0.10.0
Browse files Browse the repository at this point in the history
While working on #2263, noticed that we aren't using the most recent
version of tower-abci. This change bumps to latest, ahead of upcoming
more substantive changes in v0.11.0 [0]. Opted to preserve the TCP-only
ABCI support for pd out of simplicity.

Also includes mention of `jmt` in the cargo lockfile as a follow-up to
f482b48.

[0] penumbra-zone/tower-abci#34
  • Loading branch information
conorsch committed Oct 3, 2023
1 parent f482b48 commit c219e97
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/bin/pd/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ penumbra-tendermint-proxy = { path = "../../util/tendermint-proxy" }
# Penumbra dependencies
decaf377 = { version = "0.5", features = ["parallel"] }
decaf377-rdsa = { version = "0.7" }
tower-abci = "0.9.0"
tower-abci = "0.10.0"
jmt = "0.8"
tower-actor = "0.1.0"

Expand Down
3 changes: 2 additions & 1 deletion crates/bin/pd/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ enum RootCommand {
default_value = "127.0.0.1:26658",
display_order = 400
)]
// TODO: Add support for Unix domain sockets, available in tower-abci >=0.10.0
abci_bind: SocketAddr,
/// Bind the gRPC server to this socket.
///
Expand Down Expand Up @@ -325,7 +326,7 @@ async fn main() -> anyhow::Result<()> {
.info(info.clone())
.finish()
.context("failed to build abci server")?
.listen(abci_bind),
.listen_tcp(abci_bind),
)
.expect("failed to spawn abci server");

Expand Down
2 changes: 1 addition & 1 deletion crates/narsil/narsil/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ penumbra-chain = { path = "../../core/component/chain", features = [
penumbra-app = { path = "../../core/app" }

# Penumbra dependencies
tower-abci = "0.9.0"
tower-abci = "0.10.0"
tower-actor = "0.1.0"

# External dependencies
Expand Down
2 changes: 1 addition & 1 deletion crates/narsil/narsil/src/bin/narsild.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ async fn main() -> anyhow::Result<()> {
.info(info.clone())
.finish()
.ok_or_else(|| anyhow::anyhow!("failed to build abci server"))?
.listen(abci_bind),
.listen_tcp(abci_bind),
)
.expect("failed to spawn abci server");

Expand Down

0 comments on commit c219e97

Please sign in to comment.