Skip to content

Commit

Permalink
add comment to use NullifierDerivationCircuit client-side only (#4052)
Browse files Browse the repository at this point in the history
add note for future maintainers to only use the
`NullifierDerivationCircuit` on the client-side, since the nk is not
actually demonstrated to be associated with the address on the note in
circuit (related issue #3978)
  • Loading branch information
redshiftzero authored Mar 19, 2024
1 parent 1ec7aba commit dbc95be
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ fn check_circuit_satisfaction(
}

/// Groth16 proof for correct nullifier derivation.
///
/// # Safety
///
/// This proof is only for client-side use and not on chain. The nullifier-deriving
/// key is not linked in the circuit to the address associated with the note commitment.
#[derive(Clone, Debug)]
pub struct NullifierDerivationCircuit {
public: NullifierDerivationProofPublic,
Expand Down

0 comments on commit dbc95be

Please sign in to comment.