Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: pick a smaller value for mempool.max_tx_bytes #4629

Closed
dynst opened this issue Jun 17, 2024 · 1 comment
Closed

pd: pick a smaller value for mempool.max_tx_bytes #4629

dynst opened this issue Jun 17, 2024 · 1 comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@dynst
Copy link
Contributor

dynst commented Jun 17, 2024

In the cometbft config template, maximum individual transaction size (max_tx_bytes) should probably be smaller than the maximum block size (the consensus parameter) that just got lowered in #4597. What's a reasonable value?

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jun 17, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 17, 2024
@erwanor
Copy link
Member

erwanor commented Jun 17, 2024

We need empirical data to set a judicious default in the template, so we can revisit later, but a safe upper bound should be ~30KB. This gives ample room for a user to open a collection of replicating LPs and roll block-scoped orders.

@erwanor erwanor changed the title pick a smaller value for mempool.max_tx_bytes pd: pick a smaller value for mempool.max_tx_bytes Jun 17, 2024
@erwanor erwanor closed this as completed Jun 17, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Archived in project
Development

No branches or pull requests

2 participants