pd: review pass on config template defaults #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far so good. Thanks for taking the time to annotate the default values with descriptive comments. Standing by to provide final review, after which I'll incorporate any changed values into the migration script for #4614. |
dynst
reviewed
Jun 18, 2024
Comment on lines
+304
to
+305
| // 30KB | ||
| max_bytes: 30000, |
There was a problem hiding this comment.
Great, thanks for opening that issue.
|
I will follow up with putting the template defaults into |
conorsch
approved these changes
Jun 18, 2024
erwanor
added
the
A-node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a review on consensus params template defaults which are a bit dated like @dynst noticed.
The diff of changes:
unbonding_delay(about 130k blocks, 650k seconds)epoch_durationto17280blocks (about 1 day at5s/block)We implement validation in a follow-up PR (#4627)
Issue ticket number and link
Context in: #4635 #4632 #4629
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: