Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd(template): adjust evidence max_bytes #4635

Closed
dynst opened this issue Jun 17, 2024 · 1 comment
Closed

pd(template): adjust evidence max_bytes #4635

dynst opened this issue Jun 17, 2024 · 1 comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@dynst
Copy link
Contributor

dynst commented Jun 17, 2024

A block is comprised of 3 things: validator commitments, misbehavior evidence, and transactions.

#4597 set the maximum total block size max_bytes to 1MiB, but now it's exactly equal to misbehavior evidence max_bytes.

https://docs.rs/tendermint/0.34.1/tendermint/evidence/struct.Params.html#structfield.max_bytes

This sets the maximum size of total evidence in bytes that can be committed in a single block, and should fall comfortably under the max block bytes. The default is 1048576 or 1MB.

Should the evidence limit be decreased or the block size limit be increased?

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Jun 17, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Jun 17, 2024
@erwanor erwanor changed the title block size max_bytes should be bigger than evidence max_bytes pd(template): adjust evidence max_bytes Jun 17, 2024
@conorsch
Copy link
Contributor

Resolved by #4637.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
Archived in project
Development

No branches or pull requests

2 participants