Commits on Aug 18, 2023

1. feat(proto)!: remove optional fields in protos …

   The cosmos fork of gogoproto, used to generate golang code from BSR,
   doesn't support "optional" fields in proto3 syntax. Rather than sort
   that out, we're removing use of optional to unblock integration work on
   interchaintest.
   
   In order to preserve the representation of optionality, we use
   submessages in the proto types, so we can include or omit the named
   field. A notable exception is for encrypted memos: since the encrypted memo
   payload must be a specific length, we can check for whether it's empty,
   and map an empty encrypted memo to None.
   
   H/t to @plaidfinch for describing the submessage pattern to me,
   and implementing it on the governance changes.
   
   Closes #2933.

   

   conorsch committed Aug 18, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 04888f1
   • Browse repository at this point

   Copy the full SHA

   04888f1 View commit details

   Browse the repository at this point in the history