Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proto)!: remove optional fields in protos #2951

Merged
merged 1 commit into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. feat(proto)!: remove optional fields in protos

    The cosmos fork of gogoproto, used to generate golang code from BSR,
    doesn't support "optional" fields in proto3 syntax. Rather than sort
    that out, we're removing use of optional to unblock integration work on
    interchaintest.
    
    For the most part, we can still represent optionality by special-casing
    zero (for blockheights) and empty (for encrypted memos). The exception
    is governance protos, which require use of a submessage type to
    represent the optional "withdrawn" state on proposal outcomes.
    H/t to @plaidfinch for describing the submessage pattern to me,
    and implementing it on the governance changes.
    
    Closes #2933.
    conorsch committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    339619b View commit details
    Browse the repository at this point in the history