Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staking: add delay to reenable a validator #4068

Merged
merged 2 commits into from
Mar 22, 2024
Merged

staking: add delay to reenable a validator #4068

merged 2 commits into from
Mar 22, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Mar 21, 2024

Sketch solution to #4067, this gives a starting point to provide a justification why this solve epoch grinding and TCT index overflows.

@erwanor erwanor added A-staking Area: Design and implementation of staking and delegation zellic-component-remediated Tag PRs that are remediating Zellic findings consensus-breaking breaking change to execution of on-chain data labels Mar 21, 2024
@erwanor erwanor self-assigned this Mar 21, 2024
cratelyn
cratelyn reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a reasonable fix. should we also write a mock consensus test to ensure that this doesn't regress in the future, and that it works properly? i wouldn't block on that ask, a separate issue to prioritize afterwards would be fine with me.

@cratelyn cratelyn added this to the Sprint 2 milestone Mar 21, 2024
@erwanor
Copy link
Member Author

erwanor commented Mar 22, 2024

this seems like a reasonable fix. should we also write a mock consensus test to ensure that this doesn't regress in the future, and that it works properly? i wouldn't block on that ask, a separate issue to prioritize afterwards would be fine with me.

That's a great idea, I've been looking for an opportunity to write one so sgtm

@erwanor erwanor mentioned this pull request Mar 22, 2024
Open
@erwanor erwanor merged commit a2b1cc3 into main Mar 22, 2024
7 checks passed
@erwanor erwanor deleted the erwan/4067_delay_disable branch March 22, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn left review comments

@hdevalence hdevalence Awaiting requested review from hdevalence

Assignees

@erwanor erwanor

Labels
A-staking Area: Design and implementation of staking and delegation consensus-breaking breaking change to execution of on-chain data zellic-component-remediated Tag PRs that are remediating Zellic findings
Projects
Penumbra
Status: Done
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.
2 participants
@erwanor @cratelyn