Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release storage locks on testnet76 migration #4431

Merged
merged 1 commit into from
May 22, 2024

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented May 21, 2024

Describe your changes

Closes #4430.

Issue ticket number and link

Temporarily included testing setup from #4337, because that's how I've been validating behavior locally. Dropped that, will focus on making the logic reusable in that PR.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

highly relevant to breaking changes, given that this refines the logic. fixes the bug described in #4430

@conorsch conorsch changed the title 4430 debug migration locks fix: release storage locks on testnet76 migration May 21, 2024
@conorsch conorsch force-pushed the 4430-debug-migration-locks branch from 28680a0 to 02f459a Compare May 22, 2024 00:26
@conorsch conorsch marked this pull request as ready for review May 22, 2024 00:27
@conorsch conorsch merged commit a50d587 into main May 22, 2024
13 checks passed
@conorsch conorsch deleted the 4430-debug-migration-locks branch May 22, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

upgrades: failing to release lock on storage
2 participants