Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: check ck_d is consistent with d, pk_d provided on a note #4570

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Jun 6, 2024

Describe your changes

Issue ticket number and link

Closes #4569

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    This is only used by the view service

@redshiftzero redshiftzero marked this pull request as ready for review June 14, 2024 17:54
@cratelyn cratelyn added the A-shielded-crypto Area: Cryptographic design for Penumbra's shielded transaction model label Jun 14, 2024
@cratelyn cratelyn added this to the Sprint 8 milestone Jun 14, 2024
Copy link
Collaborator

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conorsch conorsch merged commit 20b914b into main Jun 17, 2024
13 checks passed
@conorsch conorsch deleted the check-ck-consistency branch June 17, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-shielded-crypto Area: Cryptographic design for Penumbra's shielded transaction model
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

check for clue key replacement in addresses on notes
5 participants