Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update required version for buf tool #4626

Merged
merged 1 commit into from
Jun 20, 2024
Merged

chore: update required version for buf tool #4626

merged 1 commit into from
Jun 20, 2024

Conversation

TalDerei
Copy link
Collaborator

Describe your changes

References https://github.com/bufbuild/buf/releases/tag/v1.32.0

Issue ticket number and link

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

The `buf` cli made a breaking change in `v1.32` [sic, 0], so we must
update the script invocations to keep it working. Touched up the docs
where appropriate, and ran the recommended `buf config migrate` cmd [1]
to get the files in sync with the new format. After rerunning `just
proto` on the migrated files, I see no changes.

[0] https://github.com/bufbuild/buf/releases/tag/v1.32.0
[1] https://buf.build/docs/migration-guides/migrate-v2-config-files

Co-authored-by: Conor Schaefer <[email protected]>
@conorsch conorsch marked this pull request as ready for review June 20, 2024 22:58
@conorsch
Copy link
Contributor

Thanks for submitting this, @TalDerei! I tacked on some changes to get this to green. Also refs #4404 which tinkered with the buf cli invocation in the scripts.

cc @cratelyn it'd be grand if we were tracking tooling drift like this in the nix config. I just checked, and naively adding buf to the devShell like so:

diff --git a/flake.nix b/flake.nix
index 2957ecbb3..45e16b96e 100644
--- a/flake.nix
+++ b/flake.nix
@@ -104,7 +104,7 @@
           devShells.default = craneLib.devShell {
             inherit LIBCLANG_PATH ROCKSDB_LIB_DIR;
             inputsFrom = [ penumbra ];
-            packages = [ cargo-watch cargo-nextest protobuf cometbft rocksdb ];
+            packages = [ cargo-watch cargo-nextest protobuf cometbft rocksdb buf ];
             shellHook = ''
               export LIBCLANG_PATH=${LIBCLANG_PATH}
               export RUST_SRC_PATH=${pkgs.rustPlatform.rustLibSrc} # Required for rust-analyzer

pulls in buf v1.31.0, i.e. the version before this breaking change. When I check in nix package search, looks like v1.32.0 is only available under "unstable," which is pretty convenient, given that this was a breaking change. If we did want to add 1.32, curious to learn how that'd be specified in the in-repo flake. Not adding it for now, but eager to get the first-run experience up to snuff.

@conorsch conorsch changed the title proto: update buf dependency chore: update required version for buf tool Jun 20, 2024
@conorsch conorsch merged commit b6ce49a into main Jun 20, 2024
13 checks passed
@conorsch conorsch deleted the update-buf-dep branch June 20, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants