metrics: add os-level cpu stats to pd #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to cobble together some graphs to display this new info, should be straightforward. Draft in the meantime. |
conorsch
added
the
A-telemetry
Pulls in the `metrics-process` crate [0] to bolt on CPU usage and other OS-level info to the metrics emitted by pd. Doing so will support a better first-run experience for node operators who lack a comprehensive pre-existing setup for monitoring node health, so they can get a sense of how much load pd is under. Adds a cursory first-pass on a new dashboard, but will need to follow up on that once the new metrics actually land on hosts that are receiving load. Also included a reference to metrics addd in #4581, as a treat. [0] https://docs.rs/metrics-process/2.0.0/metrics_process/index.html
Fixes a hardcoded path in the compose setup for local metrics. Updates the docs, as well, to clarify that the first-run experience via docker compose is only relevant for Linux hosts, due to use of host-networking. Will work on a macos-compatible dev env later, but for now focusing on making sure what's in the repo is clear and runnable for actual testnet node operators, which means Linux boxes. Closes #4565.
|
Ready for review. Added a new dashboard to focus on pd performance:
I'm not happy about how to translate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Pulls in the
metrics-processcrate [0] to bolt on CPU usage and other OS-level info to the metrics emitted by pd. Doing so will support a better first-run experience for node operators who lack a comprehensive pre-existing setup for monitoring node health, so they can get a sense of how much load pd is under.[0] https://docs.rs/metrics-process/2.0.0/metrics_process/index.html
Issue ticket number and link
None, was discussed briefly during sprint-planning recently.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: