Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: delete packet commitments instead of writing empty values #4644

Merged
merged 1 commit into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. ibc: delete packet commitments instead of writing empty values

    The IBC spec calls for deletion of packet commitments after a
    successful acknowledgement, in order to avoid double-acknowledgements.
    
    Previously, our implementation accomplished this deletion by writing
    an empty byte slice vec![] to the commitment path.
    
    However, this will cause nonexistence proofs by exclusion (the
    standard NX-proof type used in ics23) of adjacent keys to fail,
    since ics23 does not support existence proofs of empty values.
    
    This PR changes `delete_packet_commitment` to actually delete the
    commitment, and introduces a migration for testnet 78 that will
    delete all of the previously overwritten commitments.
    avahowell authored and erwanor committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    72d4d98 View commit details
    Browse the repository at this point in the history