Prepare v0.77.4 changeset #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, there wasn't an need to explicitly specify a _spend_ as a user intent until non-zero fees were introduced. In that context, this proto-related modification is necessary in order to allow a user to send an _entire_ balance for a specific asset. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: (cherry picked from commit d098f23)
when auto-https is enabled, we spawn a task in the background to handle https certificate resolution, via `rustls_acme::AcmeState`. if that task encounters errors, they should be propagated up to the daemon, so that `pd` does not rapidly retry lookups, potentially hitting rate-limits and causing service interruptions. this changes the `pd` entrypoint, binding the [`JoinHandle`] to a variable and polling upon that future in the `tokio::select` block that represents the core steady-state event loop of the daemon. we also update the acme_worker loop to log-and-bail on error, ensuring that pd exits when the error hits the select loop in pd main. Co-Authored-By: Conor Schaefer <[email protected]> (cherry picked from commit adf260b)
Been a few releases since the latest of these. Pulling the latest main from https://github.com/penumbra-zone/web. (cherry picked from commit 52a7fb3)
erwanor
approved these changes
Jun 25, 2024
|
lgtm |
conorsch
added a commit
that referenced
this pull request
Jun 25, 2024
1 task
conorsch
added a commit
that referenced
this pull request
Jun 25, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR backports several fixes for inclusion in the 0.77.x release series, as v0.77.4.
Issue ticket number and link
Specifically, the relevant PRs are:
TransactionPlannerRequest#4615Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: