Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp: add initial_balance to content message #4666

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Jun 25, 2024

Describe your changes

This adds an initial_balance value to the genesis content message for the CP component.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Consensus breaking

@erwanor erwanor added the A-node Area: System design and implementation for node software label Jun 25, 2024
@erwanor erwanor self-assigned this Jun 25, 2024
@conorsch
Copy link
Contributor

There's no cli integration, but with the logic added, manual munging of a genesis file would be honored. We've now got a failing test, though:

 thread 'app_can_propose_community_pool_spends' panicked at crates/core/app/tests/app_can_propose_community_pool_spends.rs:305:5:
assertion `left == right` failed: the community pool should be empty at the beginning of the chain
  left: {passet1984fctenw8m2fpl8a9wzguzp7j34d7vravryuhft808nyt9fdggqxmanqm: 0}
 right: {}

which looks rather superficial to fix: the definition of "empty" is should be summing the values of any assets and asserting zero, not assuming no assets are in there.

@conorsch conorsch merged commit d58b327 into main Jun 25, 2024
13 checks passed
@conorsch conorsch deleted the erwan/cp_genesis_content branch June 25, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: System design and implementation for node software
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants