chore(Cargo.toml): 🪄 remove explicit default-features = true
#4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in #3748, we migrated to using cargo's workspace dependencies feature. this has been excellent, workspace dependencies rock. 🎸 one wrinkle in the [script] used to migrate all of our constituent crates' manifests over was that it provided an explicit `default-features` attribute, even when `True`. default features are, by their nature, enabled by default. a dependency need only provide this attribute when _disabling_ default features, in order to e.g. explicitly provide a list of `#[cfg(..)]` features to conditionally compile into a library/binary. via the magic of vim macros and the quickfix list, this commit mechanically removes any occurrences of `default-features = true` in our dependency tree. [script]: #3748 (comment)
cratelyn
added
C-chore
|
not going to tug on those ci failures right now. i may pick this up later when i have spare cycles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #3748, we migrated to using cargo's workspace dependencies feature. this has been excellent, workspace dependencies rock. 🎸
one wrinkle in the script used to migrate all of our constituent crates' manifests over was that it provided an explicit
default-featuresattribute, even whenTrue.default features are, by their nature, enabled by default. a dependency need only provide this attribute when disabling default features, in order to e.g. explicitly provide a list of
#[cfg(..)]features to conditionally compile into a library/binary.via the magic of vim macros and the quickfix list, this commit mechanically removes any occurrences of
default-features = truein our dependency tree.checklist before requesting a review
if this code contains consensus-breaking changes, i have added the "consensus-breaking" label. otherwise, i declare my belief that there are not consensus-breaking changes, for the following reason: