Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd(generate): use constants from penumbra_app #4690

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Jul 2, 2024

Describe your changes

pd network generate and the application use consensus parameters defined in two different places which is confusing and error-prone.

This PR makes pd network generate import constants from the app.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

This only affects new runs of pd network generate.

@conorsch
Copy link
Contributor

conorsch commented Jul 2, 2024

Refs #4627, #4614.

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, @erwanor! Adding the constants was clutch, and using them where they're needed is even better.

@conorsch conorsch merged commit b54ddaf into main Jul 2, 2024
13 checks passed
@conorsch conorsch deleted the erwan/harmonize_cometbft_template branch July 2, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants