Make pindexer more easily embeddable as a library #4712
Conversation
| Self { | ||
| opts: Options::parse(), | ||
| opts, |
There was a problem hiding this comment.
I'm not sure this is desirable -- the original API was structured that way so that downstream consumers didn't have control over the CLI. Everyone gets the same binary, the only difference is which AppViews are hooked into it.
There was a problem hiding this comment.
If you want to hook in different AppViews you have to consumer pindexer as a library, in which case having control over your CLI seems much better to me, and doesn't cause odd spooky behavior.
There was a problem hiding this comment.
I don't fully understand the disagreement about exposing CLI opts: in the interest of making pindexer more accessible, e.g. via importing into other rust code, I'm biased toward making this change and dealing with the consequences later.
There was a problem hiding this comment.
Yes, this change should be rolled back, it's an explicit design goal to not allow control over the CLI, so that every Penumbra indexer has the same interface.
cronokirby
force-pushed
the
pindexer-tweaks
branch
from
f513c46
to
e2f7954
Compare
Necessary to allow implementing AppView
Makes it much more convenient to implement AppView
This allows indexer components to read the cometbft database, if necessary. This is desirable for more advanced use cases. As a safeguard, we set the connection to read only. This can be overwritten by a savvy user, but this prevents basic accidental mistakes from modifying the cometbft database.
This is better than parsing inside the library
cronokirby
force-pushed
the
pindexer-tweaks
branch
from
e2f7954
to
fbff90c
Compare
Describe your changes
We don't expose cometindex as a library, but we do pindexer, and this adds a few tweaks to make pindexer possible to run inside an external piece of Rust code. This is useful, because it allows people to colocate their indexer and their block explorer, for example.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: