gov: use saturating_sub as a defence-in-depth #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
approved these changes
Jul 17, 2024
conorsch
pushed a commit
that referenced
this pull request
Jul 26, 2024
## Describe your changes Uses saturating_sub as a defense in depth mechanism ## Issue ticket number and link ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > defense in depth in a codepath that has not been executed (cherry picked from commit f9f7028)
1 task
conorsch
added a commit
that referenced
this pull request
Jul 26, 2024
## Describe your changes The `v0.79.1` release contained two bug fixes: https://github.com/penumbra-zone/penumbra/releases/tag/v0.79.1 Those changes were committed directly to the `release/v0.79.x` branch: * #4716 * #4718 Typically, we prepare fixes for the `main` branch, then backport them via cherry-pick into the relevant release branch. That process wasn't adhered to for 0.79.1, so I'm following up to ensure we have all the relevant changes we need in main. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > These changes have already been released, as part of `v0.79.1` (and therefore `v0.79.2`), so pulling them into main just ensures we don't inadvertently unship them. --------- Co-authored-by: Henry de Valence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Uses saturating_sub as a defense in depth mechanism
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: