Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ics23 to 0.11.3, ibc-proto to 0.42.2, ibc-types to 0.14.1. Release v0.79.1 #4717

Closed
wants to merge 1 commit into from

Conversation

zbuc
Copy link
Member

@zbuc zbuc commented Jul 17, 2024

Describe your changes

  • Update ics23 to 0.11.3
  • Update ibc-proto to 0.42.2
  • Update ibc-types to 0.14.1

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    consensus and state breaking due to changes to ibc-proto. migration is necessary if any IBC data has been written to state.

@zbuc zbuc added consensus-breaking breaking change to execution of on-chain data state-breaking breaking change to on-chain data labels Jul 17, 2024
Copy link
Member

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge this, as it has state-breaking changes, it's not suitable for inclusion in the release branch.

@conorsch
Copy link
Contributor

Closing in favor of a more narrowly scoped change set. See related issue #4682. Also, this PR was made from a branch called v0.79.1 which is an ambiguous git refspec with the forthcoming tag, so I'm going to manually delete the branch after closing this PR, to ensure that in the future, git checkout v0.79.1 doesn't lead to surprises. Anyone that had this branch fetched locally should also run git branch -D v0.79.1 cc @zbuc.

@conorsch conorsch closed this Jul 17, 2024
@hdevalence
Copy link
Member

#4718 has just the ICS23 changes

@conorsch conorsch deleted the v0.79.1 branch July 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-breaking breaking change to execution of on-chain data state-breaking breaking change to on-chain data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants