Augment missing events for governance #4769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a canonical way to serialize this enum, which is useful for storing it in a database. Co-authored-by: plaidfinch <[email protected]>
This implements a few different additions to events to make governance-related indexing easier: - add the validator identity key to delegator vote events - add the voting power to validator votes - add the start and end height to proposal submissions This also renames the EventEnactProposal to EventProposalPassed, which hypothetically breaks existing consumers of that event, of which we know of none. Co-authored-by: plaidfinch <[email protected]>
|
c.f. #4708 (comment) for discussion on the lint failure |
aubrika
previously requested changes
Jul 25, 2024
Yes, it breaks anything that was using it, which at the time was only the code in that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the event related changes from #4708 and pulls them out for independent review and merging.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: