events: record EventPositionClose when closing positions manually
#4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently two ways for a position to get closed:
1. automatically by the DEX, for an auto-close position,
2. at the end of the block, after being *queued* for closure in the in
the action handler.
For 2., we weren't emitting the event.
This commit changes things so that we do, in fact, emit the event
in this case, for a position that has not yet been closed.
hdevalence
approved these changes
Jul 30, 2024
3 tasks
conorsch
pushed a commit
that referenced
this pull request
Aug 28, 2024
…4779) There are currently two ways for a position to get closed: 1. automatically by the DEX, for an auto-close position, 2. at the end of the block, after being *queued* for closure in the in the action handler. For 2., we weren't emitting the event. This commit changes things so that we do, in fact, emit the event in this case, for a position that has not yet been closed. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only adds new events. (cherry picked from commit 6981aec)
conorsch
pushed a commit
that referenced
this pull request
Aug 29, 2024
…4779) There are currently two ways for a position to get closed: 1. automatically by the DEX, for an auto-close position, 2. at the end of the block, after being *queued* for closure in the in the action handler. For 2., we weren't emitting the event. This commit changes things so that we do, in fact, emit the event in this case, for a position that has not yet been closed. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only adds new events. (cherry picked from commit 6981aec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two ways for a position to get closed:
For 2., we weren't emitting the event.
This commit changes things so that we do, in fact, emit the event in this case, for a position that has not yet been closed.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: