Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tendermint proxy code, fix proxy timestamp handling #4810

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

zbuc
Copy link
Member

@zbuc zbuc commented Aug 15, 2024

Describe your changes

This PR cleans up the tendermint proxy code by removing the usage of tonic error types and fixes a bug in the proxy timestamp handling.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    The timestamp handling change does not affect consensus because it only affects values returned to clients via the tendermint proxy, which is mostly unused. Any usage of these incorrect timestamps would be noticed as frequent and random failures which haven't been reported.

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conorsch conorsch merged commit 72bfb7d into main Aug 20, 2024
13 checks passed
@conorsch conorsch deleted the cleanup_tendermint_compat branch August 20, 2024 16:10
@conorsch conorsch mentioned this pull request Aug 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants