pcli: add display for auction transactions #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
pcli-show-auctions
branch
from
8e0497c
to
febddd2
Compare
cronokirby
force-pushed
the
pcli-show-auctions
branch
from
febddd2
to
9c9976e
Compare
cronokirby
force-pushed
the
pcli-show-auctions
branch
from
9c9976e
to
0a74628
Compare
cronokirby
force-pushed
the
pcli-show-auctions
branch
from
0a74628
to
9206ec9
Compare
4 tasks
conorsch
reviewed
Aug 15, 2024
conorsch
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This adds a rudimentary view for viewing transactions containing auctions without panicking.
Schedule
End
Withdraw
Issue ticket number and link
Closes #4813.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Follow up
There seems to be some issues in how auction views get produced, because this was an auction for "gm" on a devnet, which displays fine in other circumstances, but produces a "passet" here. Also, the reserves are empty, when I would've expected them to be populated.