Reworks the Buy/Sell order api to support creating multiple identical positions #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… positions. This is especially useful for limit orders because it allows them to be filled piece wise.
cronokirby
requested changes
Aug 15, 2024
| @@ -8,7 +8,7 @@ use penumbra_dex::{ | |||
| }, | |||
| TradingPair, | |||
| }; | |||
| use rand_core::CryptoRngCore; | |||
| use rand_core::OsRng; | |||
There was a problem hiding this comment.
I wonder if we might not be able to make this use a generic RNG for easier testing
| @@ -104,6 +104,9 @@ pub enum OrderCmd { | |||
| /// The selected fee tier to multiply the fee amount by. | |||
| #[clap(short, long, default_value_t)] | |||
| fee_tier: FeeTier, | |||
| /// Duplicate the order for the given number of times. | |||
| #[clap(short, long, default_value = "1")] | |||
| duplicate: u32, | |||
There was a problem hiding this comment.
IMO we should change this to something starting with n to match the dutch auctions
|
closing in favor of #4819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the position creation flow to support creating multiple identical positions in a single command/ planner execution. This is useful to me for creating limit order orders using auto close positions so they can be filled piecewise.