Zaki/duplicate positions #4819
Merged
Zaki/duplicate positions #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… positions. This is especially useful for limit orders because it allows them to be filled piece wise.
cronokirby
force-pushed
the
zaki/duplicate_positions
branch
from
a795bcc
to
78cda19
Compare
4 tasks
|
TY for fixing my rust |
conorsch
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
LGTM! Thanks @cronokirby for the assist on landing this quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
#4817 with some suggested fixes and a rebase.
(I had to make a new branch because of how github forked PRs work)
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: