Generate block headers properly in tests #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbuc
force-pushed
the
test_blockheader_generation
branch
from
a54b5af
to
e95eeca
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
e95eeca
to
baf55e2
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
baf55e2
to
b6090a9
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
b6090a9
to
f3d5f27
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
f3d5f27
to
2508230
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
2508230
to
197154c
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
197154c
to
d3bb5ac
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
d3bb5ac
to
eff63a7
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
eff63a7
to
f4fe7e0
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
f4fe7e0
to
5f0b44b
Compare
zbuc
force-pushed
the
test_blockheader_generation
branch
from
5f0b44b
to
702c3cf
Compare
conorsch
approved these changes
Aug 20, 2024
| ); | ||
|
|
||
| // TODO: these tests fail | ||
| if false { |
There was a problem hiding this comment.
Note to reader: see ongoing work in #4797 to get proof lookups working well.
| .try_into()?, | ||
| ), | ||
| // Address of the original proposer of the block. Validator must be in the current validatorSet. | ||
| proposer_address, |
There was a problem hiding this comment.
Thank you for the liberal commenting throughout. 🙏
| .unwrap(), | ||
| }; | ||
| let canonical = tendermint::vote::CanonicalVote { | ||
| // The mock consensus engine ONLY has precommit votes right now |
| @@ -112,7 +127,7 @@ impl<C> TestNode<C> { | |||
| &self.last_app_hash | |||
| } | |||
|
|
|||
| /// Returns the last `timestamp` value. | |||
| /// Returns the most recent `timestamp` value. | |||
| /// Returns the latest block height. | ||
| fn latest_block_height(&self) -> tendermint::block::Height { | ||
| /// Returns the last committed block height. | ||
| fn last_block_height(&self) -> tendermint::block::Height { |
There was a problem hiding this comment.
Crucially the tendermint/cometbft module docs define last_block_height as "The latest block for which the app has called Commit" which tracks with how it's being used here.
conorsch
reviewed
Aug 20, 2024
| @@ -18,7 +18,7 @@ pub mod params; | |||
| mod version; | |||
|
|
|||
| mod prefix; | |||
| pub use prefix::{IBC_COMMITMENT_PREFIX, IBC_PROOF_SPECS, IBC_SUBSTORE_PREFIX}; | |||
| pub use prefix::{MerklePrefixExt, IBC_COMMITMENT_PREFIX, IBC_PROOF_SPECS, IBC_SUBSTORE_PREFIX}; | |||
There was a problem hiding this comment.
The addition of exporting MarklePrefixExt via the penumbra-ibc crate is the only non-test change in the PR, and looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This updates the mock tendermint to properly perform block signing and header generation.
Tests should probably be added that the mock tendermint performs as expected.
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: