Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): bind to unique ports in ibc tests #4828

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Aug 22, 2024

Describe your changes

Follow-up to #4747. Noticed the new tests were flaking across multiple runs. Turns out they were fighting for port binds, as described already in #4517. Let's just use a unique port pair for the MockRelayers and call it a day for now.

Issue ticket number and link

Refs #4517.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    tests only

@conorsch
Copy link
Contributor Author

Here's an example of a failing test run: https://github.com/penumbra-zone/penumbra/actions/runs/10515320975/job/29135123028 with error text:

--- STDERR:              penumbra-app::ibc_handshake ibc_handshake ---
thread 'ibc_handshake' panicked at crates/core/app/tests/common/ibc_tests/node.rs:120:47:
grpc server returned an error: Os { code: 98, kind: AddrInUse, message: "Address already in use" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Error: could not connect to grpc server

Caused by:
    0: transport error
    1: error trying to connect: tcp connect error: Connection refused (os error 111)
    2: tcp connect error: Connection refused (os error 111)
    3: Connection refused (os error 111)

Follow-up to #4747. Noticed the new tests were flaking across multiple
runs. Turns out they were fighting for port binds, as described already
in #4517. Let's just use a unique port pair for the MockRelayers and
call it a day for now.
@conorsch conorsch requested a review from zbuc August 23, 2024 00:03
@conorsch conorsch changed the title TEMPORARY: no-op edit for debugging ci fix(tests): bind to unique ports in ibc tests Aug 23, 2024
@conorsch conorsch marked this pull request as ready for review August 23, 2024 00:03
@conorsch conorsch merged commit 96af7eb into main Aug 23, 2024
13 checks passed
@conorsch conorsch deleted the ci-debug-ibc-handshake branch August 23, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants