Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly sum Penumbra-minted values returned in total supply API #4836

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

zbuc
Copy link
Member

@zbuc zbuc commented Aug 26, 2024

Describe your changes

This fixes an issue in the TotalSupply API where tokens minted on Penumbra and received from different counterparties weren't correctly summing together.

It should be noted that this API returns two subtly different values depending on the asset:

  • For a Penumbra-minted token, it's really the "Total Outstanding IBC Supply" API rather than the "Total Supply" API -- it will return the amount of the token that has been sent to and remains on other chains
  • For an externally-originating token, it indicates the total supply of the token transferred into and remaining on the Penumbra chain

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    no consensus changes

@conorsch conorsch merged commit 09a5900 into main Sep 10, 2024
13 checks passed
@conorsch conorsch deleted the total_ibc_supply_fix branch September 10, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants