Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.79.4 changeset #4843

Merged
merged 1 commit into from
Aug 29, 2024

Commits on Aug 28, 2024

  1. events: record EventPositionClose when closing positions manually (#…

    …4779)
    
    There are currently two ways for a position to get closed:
    
      1. automatically by the DEX, for an auto-close position,
    2. at the end of the block, after being *queued* for closure in the in
    the action handler.
    
    For 2., we weren't emitting the event.
    This commit changes things so that we do, in fact, emit the event in
    this case, for a position that has not yet been closed.
    
    ## Checklist before requesting a review
    
    - [x] If this code contains consensus-breaking changes, I have added the
    "consensus-breaking" label. Otherwise, I declare my belief that there
    are not consensus-breaking changes, for the following reason:
    
      > Only adds new events.
    
    (cherry picked from commit 6981aec)
    cronokirby authored and conorsch committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    d8cbea1 View commit details
    Browse the repository at this point in the history