pcli migrate balance: replicate account structure #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the migrate balance command to replicate the balances of each asset per account, as required. Previously, the command would move all the values into the 0 account. This will pull fees from the account with the most amount of the staking / fee token. This differs slightly from iterating through account numbers starting from 0, but is much much simpler.
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
To test this, I prepared two wallets, one with hefty genesis allocations, and one completely empty. Results are below. wallet 1, initial balancewallet 2, initial balancewallet 1, post-migration balancewallet 2, post-migration balanceWorks as advertised: assets were slotted into matching accounts in the dest wallet, and only the staking token had different amounts, due to fees. Coupled with the changes in #4842, this satisfies all spec in #4831. |
conorsch
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the migrate balance command to replicate the balances of each asset per account, as required.
Previously, the command would move all the values into the 0 account.
This will pull fees from the account with the most amount of the staking / fee token.
This differs slightly from iterating through account numbers starting from 0, but is much much simpler.
Issue ticket number and link
Closes #4831.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: