Basic ICS23 Transfer Test #4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbuc
force-pushed
the
4846_ics23_test
branch
from
72ba013
to
a055380
Compare
zbuc
force-pushed
the
4846_ics23_test
branch
from
a055380
to
c3ee89a
Compare
zbuc
force-pushed
the
4846_ics23_test
branch
from
c3ee89a
to
242b28a
Compare
conorsch
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Replaces the existing IBC handshake test with a full ICS23 transfer test. Only the "happy path" (no timeouts or any other error cases) is tested in this initial spike.
Also introduces some improvements to the underlying
MockClientto support spent note tracking.The transfer implementation in the
MockRelayeris currently hardcoded to transfer 50% of the first chain's client's first note to the second chain; this can be fleshed out further in response to future test requirements.Issue ticket number and link
Closes #4846
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: